Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force new AS-SETs to be structured hierarchically #408

Closed
job opened this issue Nov 3, 2020 · 3 comments · Fixed by #413
Closed

Force new AS-SETs to be structured hierarchically #408

job opened this issue Nov 3, 2020 · 3 comments · Fixed by #413
Assignees
@mxsasha
Projects
NTT Support Contract 2020
Milestone
Release 4.2

Comments

@job
Copy link
Member

job commented Nov 3, 2020

There are two naming variants possible when creating AS-SET objects: flat (example: AS-SNIJDERS) or hierarchical (example: AS15562:AS-SNIJDERS).

A next version of IRRd would probably benefit from encouraging users to create AS-SET objects following the hierarchical convention, this can be achieved by rejecting new AS-SET objects that do not follow the hierarchical convention.

The submitter of the object should be presented with a clear error and a suggestion what to do instead of a flat name.

Thoughts?
@job
Copy link
Member Author

job commented Nov 3, 2020

Benefits of hierarchical naming: helps avoid naming collisions, and also helps identify which BGP network the AS-SET object relates to

@mxsasha
Copy link
Collaborator

mxsasha commented Nov 3, 2020

Seems reasonable. So the effective requirement would be: each newly created as-set in an authoritative database, should start with "ASxxxx:"?

@job
Copy link
Member Author

job commented Nov 3, 2020

Yes

@mxsasha mxsasha self-assigned this Nov 3, 2020
@mxsasha mxsasha added this to To do in NTT Support Contract 2020 via automation Nov 3, 2020
@mxsasha mxsasha added this to the Release 4.2 milestone Nov 3, 2020
@mxsasha mxsasha linked a pull request Nov 10, 2020 that will close this issue
Fix #408 - Force new AS-SETs to be structured hierarchically #413
Merged
@mahtin mahtin mentioned this issue Nov 10, 2020
Closed
NTT Support Contract 2020 automation moved this from To do to Done Nov 10, 2020
mxsasha added a commit that referenced this issue Nov 10, 2020
@mxsasha
Fix #408 - Force new AS-SETs to be structured hierarchically (#413)
a6af0f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxsasha mxsasha

Labels
None yet
Projects
No open projects
NTT Support Contract 2020
  
Done
Milestone
Release 4.2
Development

Successfully merging a pull request may close this issue.

Fix #408 - Force new AS-SETs to be structured hierarchically irrdnet/irrd
2 participants
@mxsasha @job